Skip to content

feat: sanitize javascript url #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged

feat: sanitize javascript url #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: sanitize javascript url
  • Loading branch information
@gtsp233
gtsp233 committed Dec 1, 2023
commit c5bbc31f37f824334e0c8d582709e2320ac7a455
10 changes: 9 additions & 1 deletion src/lib/src/components/NavBar/NavBarLink/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import React from "react";

const isJavaScriptProtocol = /^[\u0000-\u001F ]*j[\r\n\t]*a[\r\n\t]*v[\r\n\t]*a[\r\n\t]*s[\r\n\t]*c[\r\n\t]*r[\r\n\t]*i[\r\n\t]*p[\r\n\t]*t[\r\n\t]*\:/i

const NavBarLink = (props) => {

const {
Expand All @@ -12,9 +14,15 @@ const NavBarLink = (props) => {
onClick,
showBadge,
imgBorderRadius,
badgeBackgroundColor
badgeBackgroundColor,
allowJavaScriptUrls = true
} = props;

if (isJavaScriptProtocol.test(href) && !allowJavaScriptUrls) {
console.warn(`NavBarLink has blocked a javascript: URL as a security precaution`);
return null;
}

const renderBadge = () => {
if(showBadge > 0 || showBadge !== "") {
return <div className="app-badge"
Expand Down