adding skip_push option and tags option#1
Merged
vishnuchalla merged 2 commits intovishnuchalla:push_pullsfrom Oct 1, 2024
Merged
adding skip_push option and tags option#1vishnuchalla merged 2 commits intovishnuchalla:push_pullsfrom
vishnuchalla merged 2 commits intovishnuchalla:push_pullsfrom
Conversation
| ] | ||
| tags.extend(repo_tags) | ||
|
|
||
| explicit_tags = env_config["tags"].split(",") |
Owner
There was a problem hiding this comment.
right above this block, there is logic to generate repo tags which is redundant. Can we create branching here so that when we specify explicit tags, there is only one loop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two new options
SKIP_PUSHandTAGSto help with load testing of the registry proxy.SKIP_PUSHcan be set to true whenTEST_PHASES=PUSH_PULLto skip the first step of pushing tags to the registry.TAGSis a list of tags in a comma-separated string.Example config:
Fixes