Skip to content

chore: remove duplicated logic in vanilla template #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 3 commits into from
Sep 22, 2022
Merged

chore: remove duplicated logic in vanilla template #10145

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53e1234
Remove duplicated logic in vanilla example
curran Sep 16, 2022
8b03dc1
Merge branch 'vitejs:main' into patch-1
curran Sep 21, 2022
eed271e
Remove duplicated logic in TypeScript example
curran Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove duplicated logic in TypeScript example
  • Loading branch information
@curran
curran committed Sep 21, 2022
commit eed271ecb2dee13132b1e3c52bc501fffdd35f46
2 changes: 1 addition & 1 deletion packages/create-vite/template-vanilla-ts/src/counter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ export function setupCounter(element: HTMLButtonElement) {
counter = count
element.innerHTML = `count is ${counter}`
}
element.addEventListener('click', () => setCounter(++counter))
element.addEventListener('click', () => setCounter(counter + 1))
setCounter(0)
}