Skip to content

feat(create-vite): support create-vite-extra#10214

Merged
patak-cat merged 4 commits intomainfrom
create-vite-extra
Oct 14, 2022
Merged

feat(create-vite): support create-vite-extra#10214
patak-cat merged 4 commits intomainfrom
create-vite-extra

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Sep 23, 2022

Description

Add create-vite-extra under new Others option in framework selection:

✔ Project name: … vite-project
✔ Select a framework: › Others
? Select a variant: › - Use arrow-keys. Return to submit.
❯   create-vite-extra ↗

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 23, 2022
@patak-cat
Copy link
Copy Markdown
Member

I think this is a good idea, allowing folks to reach out for a curated list of templates without adding extra burden on the Vite Core repo. Let's discuss it in today's meeting.

Do you know why Others doesn't get underlined when selected? Not a big deal, it was just a bit surprising when I tested it.

@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented Sep 23, 2022

Seems like using the reset color removes the underline, all perhaps we can choose a different color.

patak-cat
patak-cat previously approved these changes Sep 23, 2022
@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented Sep 25, 2022

From last meeting's discussion, I've moved create-vite-extra under the new Others option in the framework selection step. I also added for options that open a new CLI.

@patak-cat patak-cat merged commit 8116cbd into main Oct 14, 2022
@patak-cat patak-cat deleted the create-vite-extra branch October 14, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants