Conversation
patak-cat
approved these changes
Sep 23, 2022
Member
patak-cat
left a comment
There was a problem hiding this comment.
Let's merge this one for now. cc @sapphi-red since you were checking the deps PR. I did re-run several times CI for it. Let's keep an eye on HMR and review this again before releasing 3.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry this test 3 times 😬
vite/playground/ssr-vue/__tests__/ssr-vue.spec.ts
Lines 164 to 171 in ea09fde
We're not editing any files before that tests so I'm not sure what's causing the flakiness. I think it started after the dep upgrade PR: #10160