Skip to content

fix(hmr): trigger hmr for missing file import errored module after file creation #16303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 4 commits into from
Mar 29, 2024
Merged

fix(hmr): trigger hmr for missing file import errored module after file creation #16303

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ed9c62
fix(hmr): don't mutate module graph when collecting modules
sapphi-red Mar 29, 2024
cf26378
test(hmr): trigger hmr for missing file import errored module after f…
sapphi-red Mar 29, 2024
9aaaaa0
fix(hmr): trigger hmr for missing file import errored module after fi…
sapphi-red Mar 29, 2024
f2f6a9c
chore: merge main
sapphi-red Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(hmr): don't mutate module graph when collecting modules
  • Loading branch information
@sapphi-red
sapphi-red committed Mar 29, 2024
commit 4ed9c62fe1d442088d601bfd83c971f2ec9ce9f1
2 changes: 1 addition & 1 deletion packages/vite/src/node/server/hmr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export async function handleHMRUpdate(
return
}

const mods = moduleGraph.getModulesByFile(file) || new Set()
const mods = new Set(moduleGraph.getModulesByFile(file))
if (type === 'create' || type === 'delete') {
for (const mod of getAffectedGlobModules(file, server)) {
mods.add(mod)
Expand Down