Skip to content

fix(css): page reload was not happening with .css?raw #16455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 2 commits into from
May 18, 2024
Merged

fix(css): page reload was not happening with .css?raw #16455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d20fd5e
fix(css): page reload was not happening with .css?raw
sapphi-red Apr 18, 2024
16c3a99
chore: merge main
sapphi-red Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vite/src/node/plugins/importAnalysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
CLIENT_PUBLIC_PATH,
DEP_VERSION_RE,
FS_PREFIX,
SPECIAL_QUERY_RE,
} from '../constants'
import {
debugHmr,
Expand Down Expand Up @@ -743,7 +744,8 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
// update the module graph for HMR analysis.
// node CSS imports does its own graph update in the css-analysis plugin so we
// only handle js graph updates here.
if (!isCSSRequest(importer)) {
// note that we want to handle .css?raw and .css?url here
if (!isCSSRequest(importer) || SPECIAL_QUERY_RE.test(importer)) {
// attached by pluginContainer.addWatchFile
const pluginImports = (this as any)._addedImports as
| Set<string>
Expand Down
10 changes: 10 additions & 0 deletions playground/css/__tests__/css.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,16 @@ test('?raw', async () => {
expect(await rawImportCss.textContent()).toBe(
readFileSync(require.resolve('../raw-imported.css'), 'utf-8'),
)

if (!isBuild) {
editFile('raw-imported.css', (code) =>
code.replace('color: yellow', 'color: blue'),
)
await untilUpdated(
() => page.textContent('.raw-imported-css'),
'color: blue',
)
}
})

test('import css in less', async () => {
Expand Down