Skip to content

fix(proxy): rewrite the origin header to match the target for ws proxy #16558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 4 commits into from
May 29, 2024
Merged

fix(proxy): rewrite the origin header to match the target for ws proxy #16558

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d60041
Rewrite the origin header to match the target for ws proxy
johnhunterarenko Apr 29, 2024
d14bbb7
Update the docs to clarify the changeOrigin option
johnhunterarenko Apr 30, 2024
b9ebeea
Rewrite Origin header if changeOrigin is true
johnhunterarenko May 14, 2024
8019aea
Update docs to reflect change
johnhunterarenko May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update the docs to clarify the changeOrigin option 
This is misleadingly named in http-proxy
  • Loading branch information
@johnhunterarenko
johnhunterarenko committed Apr 30, 2024
commit d14bbb7630114e31ad28793fdd5400ce7391a6b0
2 changes: 1 addition & 1 deletion docs/config/server-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Configure custom proxy rules for the dev server. Expects an object of `{ key: op

Note that if you are using non-relative [`base`](/config/shared-options.md#base), you must prefix each key with that `base`.

Extends [`http-proxy`](https://github.com/http-party/node-http-proxy#options). Additional options are [here](https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/middlewares/proxy.ts#L13).
Extends [`http-proxy`](https://github.com/http-party/node-http-proxy#options). Additional options are [here](https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/middlewares/proxy.ts#L13). Note that the `changeOrigin` option changes host header to match the target URL, the origin header is always changed to match the target.

In some cases, you might also want to configure the underlying dev server (e.g. to add custom middlewares to the internal [connect](https://github.com/senchalabs/connect) app). In order to do that, you need to write your own [plugin](/guide/using-plugins.html) and use [configureServer](/guide/api-plugin.html#configureserver) function.

Expand Down