Skip to content

fix: show error if vite client cannot be loaded #17419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-dev merged 4 commits into from
Jul 18, 2024
Merged

fix: show error if vite client cannot be loaded #17419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f774b2
fix: show error if vite client cannot be loaded
benmccann Jun 7, 2024
b7ef514
render the error in html only if the error overlay fails to load
benmccann Jun 13, 2024
638997d
Merge branch 'main' into benmccann-patch-1
bluwy Jul 18, 2024
30b9310
chore: improve logging
bluwy Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: show error if vite client cannot be loaded
  • Loading branch information
@benmccann
benmccann committed Jun 11, 2024
commit 1f774b24f0ea3199d34a23a3b1b1409955154fbb
2 changes: 2 additions & 0 deletions packages/vite/src/node/server/middlewares/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ export function errorMiddleware(
</script>
</head>
<body>
<h1>Internal Server Error</h1>
<pre>${err.stack?.replace(/</g, '&lt;')}</pre>
</body>
</html>
`)
Expand Down
2 changes: 1 addition & 1 deletion playground/html/__tests__/html.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ describe.runIf(isServe)('invalid', () => {
const errorOverlay = await page.waitForSelector('vite-error-overlay')
expect(errorOverlay).toBeTruthy()

await page.click('html')
await page.click('html', { position: { x: 50, y: 50 } })
const isVisbleOverlay = await errorOverlay.isVisible()
expect(isVisbleOverlay).toBeFalsy()
})
Expand Down