feat: add custom Angular variants#18410
Conversation
patak-cat
added
the
p2-nice-to-have
patak-cat
left a comment
patak-cat
left a comment
There was a problem hiding this comment.
Having a single variant is a bit strange at first, but I think it is a good idea to keep the option even if there is a single choice. We would be sending the wrong message if we directly forward to Analog. It would be great if we could add an Angular option soon though.
I'll add it now I added the standard Angular CLI command |
gioboa
changed the title
|
Nice! Recommendation would be to change |
I'll do it right now. |
| name: 'custom-angular', | ||
| display: 'Angular ↗', | ||
| color: red, | ||
| customCommand: 'npx -p @angular/cli@latest ng new TARGET_DIR', |
There was a problem hiding this comment.
@gioboa Could this be npm exec @angular/cli@latest new TARGET_DIR instead? create-vite has special handling to execute the CLI with yarn/pnpm/bun dynamically if npm exec here is used, depending on the package manager that invoked create-vite in the first place.
There was a problem hiding this comment.
Yep, it's working.
I created the PR #18425
Thanks
4 participants
Based on the feedback of #18330 I created this Angular variant
Angular CLI & Analog.js