feat: add ssr.resolve.mainFields option
#18646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: ssr
p3-downstream-blocker
patak-dev
approved these changes
Nov 12, 2024
bluwy
approved these changes
Nov 13, 2024
hi-ogawa
approved these changes
Nov 13, 2024
sheremet-va
approved these changes
Nov 13, 2024
Member
Author
|
OK. Let's merge this one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #18395, we made
resolve.mainFieldsnot to be used for no-externalized dependencies in SSR. To achieve that behavior, users now have to reach out to the Environment API (environments.ssr.resolve.mainFields).To avoid that happening, this PR adds
ssr.resolve.mainFieldsoption that is similar tossr.resolve.conditions.refs vitest-dev/vitest#6896