fix(create-vite): change create-app prompt to not remove existing files by default#18710
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Nov 21, 2024
Merged
fix(create-vite): change create-app prompt to not remove existing files by default#18710sapphi-red merged 1 commit intovitejs:mainfrom
sapphi-red merged 1 commit intovitejs:mainfrom
Conversation
This seems like a dangerously destructive option to have as the default. I switched the default to be cancel.
texuf
changed the title
texuf
changed the title
texuf
changed the title
texuf
changed the title
bluwy
approved these changes
Nov 20, 2024
sapphi-red
added
p2-edge-case
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the create app script was run in a directory with files (say ~), the default option is to delete all files and install the app.
This seems like a dangerously destructive option to have as the default. I switched the default to be cancel.