fix(optimizer): trigger onCrawlEnd after manual included deps are registered

[sapphi-red]

Description

When the optimizer runs before manual included deps are registered, Vite indefinitely stalled the request to optimized files.

I guess this rarely happens.
It happens when runOptimizer in this onCrawlEnd is called while the promise of addManuallyIncludedOptimizeDeps(environment, manuallyIncludedDeps) is pending.

vite/packages/vite/src/node/optimizer/optimizer.ts

Line 165 in a384d8f

environment.waitForRequestsIdle().then(onCrawlEnd)

vite/packages/vite/src/node/optimizer/optimizer.ts

Line 174 in a384d8f

await addManuallyIncludedOptimizeDeps(environment, manuallyIncludedDeps)

Changing the code like below would make it constantly reproduce the problem with react template of create-vite.

-      environment.waitForRequestsIdle().then(onCrawlEnd)
+      // environment.waitForRequestsIdle().then(onCrawlEnd)
      waitingForCrawlEnd = true

      // Enter processing state until crawl of static imports ends
      currentlyProcessing = true

      // Initialize discovered deps with manually added optimizeDeps.include info

      const manuallyIncludedDeps: Record<string, string> = {}
      await addManuallyIncludedOptimizeDeps(environment, manuallyIncludedDeps)

+      startNextDiscoveredBatch()
+      await runOptimizer()

      const manuallyIncludedDepsInfo = toDiscoveredDependencies(
        environment,
        manuallyIncludedDeps,
        sessionTimestamp,
      )

[bluwy]

Makes sense to me based on the explanation 👍