Skip to content

ci: update react-swc plugin version in create-vite by renovate #19394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 2 commits into from
Feb 13, 2025
Merged

ci: update react-swc plugin version in create-vite by renovate #19394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edbdf41
ci: update react-swc plugin version in create-vite by renovate
sapphi-red Feb 10, 2025
d5334d6
chore: update fileMatch
sapphi-red Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,13 @@
// breaking changes
"kill-port", // `kill-port:^2.0.0 has perf issues (#8392)
],
"customManagers": [
{
"customType": "regex",
"fileMatch": ["packages\/create-vite\/src\/index\\.ts$"],
"matchStrings": [
"\/\/\\s*renovate:\\s+datasource=(?<datasource>\\S+)\\s+depName=(?<depName>\\S+)\\s+(?:var|let|const)\\s+\\S+\\s*=\\s*[\"'](?<currentValue>[^\"']+)[\"']",
],
},
],
}
5 changes: 4 additions & 1 deletion packages/create-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,13 @@ function pkgFromUserAgent(userAgent: string | undefined): PkgInfo | undefined {
}

function setupReactSwc(root: string, isTs: boolean) {
// renovate: datasource=npm depName=@vitejs/plugin-react-swc
const reactSwcPluginVersion = '3.7.2'
Copy link
Member Author

@sapphi-red sapphi-red Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const reactSwcPluginVersion = '3.7.2'
const reactSwcPluginVersion = '3.7.0'

I'm not sure how to test this PR. Maybe setting a lower version so that renovate tries to update it?

Copy link
Member

@bluwy bluwy Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with not testing this for now. Verifying the regex manually it seems that it should work as expected though.


editFile(path.resolve(root, 'package.json'), (content) => {
return content.replace(
/"@vitejs\/plugin-react": ".+?"/,
`"@vitejs/plugin-react-swc": "^3.7.2"`,
`"@vitejs/plugin-react-swc": "^${reactSwcPluginVersion}"`,
)
})
editFile(
Expand Down