Skip to content

feat: show friendly error for malformed base #19616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-dev merged 1 commit into from
Mar 10, 2025
Merged

feat: show friendly error for malformed base #19616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/vite/src/node/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,7 +1418,7 @@ export async function resolveConfig(
inlineConfig,
root: resolvedRoot,
base,
decodedBase: decodeURI(base),
decodedBase: decodeBase(base),
rawBase: resolvedBase,
publicDir: resolvedPublicDir,
cacheDir,
Expand Down Expand Up @@ -1678,6 +1678,16 @@ export function resolveBaseUrl(
return base
}

function decodeBase(base: string): string {
try {
return decodeURI(base)
} catch {
throw new Error(
'The value passed to "base" option was malformed. It should be a valid URL.',
)
}
}

export function sortUserPlugins(
plugins: (Plugin | Plugin[])[] | undefined,
): [Plugin[], Plugin[], Plugin[]] {
Expand Down