Skip to content

fix(build): fix ssr environment emitAssets: true when sharedConfigBuild: true #20787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 5 commits into from
Sep 18, 2025
Merged

fix(build): fix ssr environment emitAssets: true when sharedConfigBuild: true #20787

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6c8cdf
fix(build): fix ssr environment emitAssets with sharedConfigBuild
hi-ogawa Sep 17, 2025
b80320e
test: actually build
hi-ogawa Sep 17, 2025
d42c470
test: cleanup
hi-ogawa Sep 17, 2025
1cfb722
Merge branch 'main' into 09-17-fix_build_fix_ssr_environment_emitasse…
hi-ogawa Sep 18, 2025
7093dba
fix: check sharedConfigBuild
hi-ogawa Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: cleanup
  • Loading branch information
@hi-ogawa
hi-ogawa committed Sep 17, 2025
commit d42c470e6bf7efc34c19fe22b7541b4d5c86e732
36 changes: 14 additions & 22 deletions packages/vite/src/node/__tests__/build.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,34 +905,26 @@ test('sharedConfigBuild and emitAssets', async () => {
},
})

expect([
builder.environments.client.config.build.emitAssets,
builder.environments.ssr.config.build.emitAssets,
builder.environments.custom.config.build.emitAssets,
]).toEqual([true, true, true])
expect(
['client', 'ssr', 'custom'].map(
(name) => builder.environments[name].config.build.emitAssets,
),
).toEqual([true, true, true])

await builder.buildApp()

expect(
await Promise.all([
fsp.readdir(
resolve(
root,
builder.environments.client.config.build.outDir,
'assets',
),
),
fsp.readdir(
resolve(root, builder.environments.ssr.config.build.outDir, 'assets'),
),
fsp.readdir(
resolve(
root,
builder.environments.custom.config.build.outDir,
'assets',
await Promise.all(
['client', 'ssr', 'custom'].map((name) =>
fsp.readdir(
resolve(
root,
builder.environments[name].config.build.outDir,
'assets',
),
),
),
]),
),
).toEqual([
expect.arrayContaining([expect.stringMatching(/\.css$/)]),
expect.arrayContaining([expect.stringMatching(/\.css$/)]),
Expand Down
Loading