Skip to content

fix(glob): fix HMR for array patterns with exclusions #20872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 9 commits into from
Oct 2, 2025
Merged

fix(glob): fix HMR for array patterns with exclusions #20872

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c9293d
fix(import-glob): fix HMR for array patterns with exclusions
abbasyed Oct 2, 2025
b578b8c
test: fix array pattern test navigation issue
abbasyed Oct 2, 2025
c0497c3
test: improve array pattern test isolation and robustness
abbasyed Oct 2, 2025
3808aa9
fix: restore HTML structure to fix existing tests
abbasyed Oct 2, 2025
b790393
test: add polling to array pattern exclusion test
abbasyed Oct 2, 2025
c806828
fix: correct polling syntax in array pattern test
abbasyed Oct 2, 2025
03d1022
test: add polling to flaky glob-import tests
abbasyed Oct 2, 2025
fea96e4
test: add polling to escape special chars test
abbasyed Oct 2, 2025
05c5be2
test: align code with other parts
sapphi-red Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: restore HTML structure to fix existing tests 
Move array pattern test to end of HTML to avoid breaking
existing test selectors and page structure.
  • Loading branch information
@abbasyed
abbasyed committed Oct 2, 2025
commit 3808aa9f4d5d0158d30d0f0084e03a48b1cba28d
5 changes: 3 additions & 2 deletions playground/glob-import/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ <h2>In package</h2>
<pre class="in-package"></pre>
<h2>Base</h2>
<pre class="result-base"></pre>
<h2>Array Pattern with Exclusions</h2>
<pre class="array-result"></pre>

<script type="module" src="./dir/index.js"></script>
<script type="module">
Expand Down Expand Up @@ -190,6 +188,9 @@ <h2>Array Pattern with Exclusions</h2>
)
</script>

<h2>Array Pattern with Exclusions</h2>
<pre class="array-result"></pre>

<script type="module">
const arrayModules = import.meta.glob(
['./array-test-dir/*.js', '!./array-test-dir/excluded.js'],
Expand Down
Loading