Skip to content

fix(esbuild): inject esbuild helpers correctly for esbuild 0.25.9+ #20906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
Oct 14, 2025
Merged

fix(esbuild): inject esbuild helpers correctly for esbuild 0.25.9+ #20906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(esbuild): inject esbuild helpers correctly for esbuild 0.25.9+
  • Loading branch information
@sapphi-red
sapphi-red committed Oct 8, 2025
commit af3eb103d565ee0221fb2899df12a56864b050c0
15 changes: 12 additions & 3 deletions packages/vite/src/node/__tests__/plugins/esbuild.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,19 @@ describe('transformWithEsbuild', () => {
describe('injectEsbuildHelpers', () => {
test('injects helpers in IIFE format', () => {
const esbuildCode =
'var $=function(){};var MyLib=function(){"use strict";return 42;}'
'var $=function(){};var MyLib=(function(){"use strict";return 42;})()'
const result = injectEsbuildHelpers(esbuildCode, 'iife')
expect(result).toBe(
'var MyLib=function(){"use strict";var $=function(){};return 42;}',
'var MyLib=(function(){"use strict";var $=function(){};return 42;})()',
)
})

test('injects helpers in IIFE format (pre esbuild 0.25.9)', () => {
const esbuildCode =
'var $=function(){};var MyLib=function(){"use strict";return 42;}()'
const result = injectEsbuildHelpers(esbuildCode, 'iife')
expect(result).toBe(
'var MyLib=function(){"use strict";var $=function(){};return 42;}()',
)
})

Expand All @@ -419,7 +428,7 @@ describe('injectEsbuildHelpers', () => {

test('handles helpers with special characters', () => {
const esbuildCode =
'var $$=function(){};var MyLib=function(){"use strict";return 42;}'
'var $$=function(){};var MyLib=(function(){"use strict";return 42;})()'
const result = injectEsbuildHelpers(esbuildCode, 'iife')
expect(result).toContain('"use strict";var $$=function(){};')
})
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/esbuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const debug = createDebugger('vite:esbuild')
// IIFE content looks like `var MyLib = function() {`.
// Spaces are removed and parameters are mangled when minified
const IIFE_BEGIN_RE =
/(?:const|var)\s+\S+\s*=\s*function\([^()]*\)\s*\{\s*"use strict";/
/(?:const|var)\s+\S+\s*=\s*\(?function\([^()]*\)\s*\{\s*"use strict";/

const validExtensionRE = /\.\w+$/
const jsxExtensionsRE = /\.(?:j|t)sx\b/
Expand Down