Skip to content

perf(module-runner): add client-side builtin module check #20924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 13 commits into from
Oct 22, 2025
Merged

perf(module-runner): add client-side builtin module check #20924

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e2e0a6b
feat: add client-side builtin module check in module runner
jiji-hoon96 Oct 13, 2025
ff1d8ac
feat: lazy load builtins from server instead of requiring upfront con…
jiji-hoon96 Oct 15, 2025
d29340a
refactor: remove unused builtins option from ModuleRunner
jiji-hoon96 Oct 20, 2025
822c4ee
test: add test for resolving builtin modules without server round-tri…
jiji-hoon96 Oct 20, 2025
c45fb67
chore: merge main
sapphi-red Oct 20, 2025
5ebe9fd
chore: fix merge
sapphi-red Oct 20, 2025
b9b2de4
refactor: share createIsBuiltin
sapphi-red Oct 20, 2025
993331b
fix: avoid memory leak and retry on error
sapphi-red Oct 20, 2025
e3e26ee
chore: minor refactor
sapphi-red Oct 20, 2025
410efa1
chore: minor refactor
sapphi-red Oct 20, 2025
763e1ed
chore: fix merge
sapphi-red Oct 20, 2025
39a3aa5
chore: revert unnecessary change
sapphi-red Oct 20, 2025
ae82e2d
chore: merge main
sapphi-red Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: minor refactor
  • Loading branch information
@sapphi-red
sapphi-red committed Oct 20, 2025
commit 410efa1cae81af15ce16d34e7469a9ca5b39a9ff
20 changes: 9 additions & 11 deletions packages/vite/src/module-runner/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,18 +275,16 @@ export class ModuleRunner {

const fetchedModule = // fast return for established externalized pattern
(
url.startsWith('data:')
url.startsWith('data:') || this.isBuiltin?.(url)
? { externalize: url, type: 'builtin' }
: this.isBuiltin?.(url)
? { externalize: url, type: 'builtin' }
: await this.transport.invoke('fetchModule', [
url,
importer,
{
cached: isCached,
startOffset: this.evaluator.startOffset,
},
])
: await this.transport.invoke('fetchModule', [
url,
importer,
{
cached: isCached,
startOffset: this.evaluator.startOffset,
},
])
) as ResolvedResult

if ('cache' in fetchedModule) {
Expand Down
Loading