Skip to content

fix(server): Listen only to 127.0.0.1 by default #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 12 commits into from
May 5, 2021
Merged

fix(server): Listen only to 127.0.0.1 by default #2977

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c61214c
fix(server): Listen only to 127.0.0.1 by default
eirslett Apr 13, 2021
1377b03
fix(server): Adjust CLI output regarding which IPs the server listens to
eirslett Apr 16, 2021
a388e27
feat(cli): The --host flag can be run without arguments
eirslett Apr 16, 2021
af7b24d
feat(cli): Tweak --host parameter: be even more explicit about defaults
eirslett Apr 17, 2021
491d0c0
fix(tests): listen on host 0.0.0.0 when running tests
eirslett Apr 21, 2021
2fde214
fix(tests): Try listening on :: to see if that fixes the unit tests o…
eirslett May 2, 2021
46cd6e9
improvement to docs
eirslett May 3, 2021
c0fd438
fix(tests): Revert "fix(tests): Try listening on :: to see if that fi…
eirslett May 3, 2021
7e4063e
fix(tests): Revert "fix(tests): listen on host 0.0.0.0 when running t…
eirslett May 3, 2021
890e41c
fix(tests): Server config listen to :: by default in all tests
eirslett May 3, 2021
dec1334
Update packages/vite/src/node/preview.ts
eirslett May 4, 2021
940f525
fix(server): Use hostname undefined instead of 0.0.0.0 or ::
eirslett May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(server): Adjust CLI output regarding which IPs the server listens to
  • Loading branch information
@eirslett
eirslett committed May 2, 2021
commit 1377b03958811e3f93961a7e7e60b730bffb3d53
6 changes: 2 additions & 4 deletions packages/vite/src/node/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,8 @@ export async function preview(
)
if (hostname === '127.0.0.1') {
const url = `${protocol}://localhost:${chalk.bold(port)}${base}`
logger.info(` > ${chalk.cyan(url)}`)
logger.info(
` (run Vite with paramater --host 0.0.0.0 to listen to all network interfaces)`
)
logger.info(` > Local: ${chalk.cyan(url)}`)
logger.info(` > Network: ${chalk.dim('use `--host` to expose')}`)
} else {
const interfaces = os.networkInterfaces()
Object.keys(interfaces).forEach((key) =>
Expand Down
6 changes: 2 additions & 4 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,10 +567,8 @@ async function startServer(

if (hostname === '127.0.0.1') {
const url = `${protocol}://localhost:${chalk.bold(port)}${base}`
info(` > ${chalk.cyan(url)}`)
info(
` (run Vite with paramater --host 0.0.0.0 to listen to all network interfaces)`
)
info(` > Local: ${chalk.cyan(url)}`)
info(` > Network: ${chalk.dim('use `--host` to expose')}`)
} else {
const interfaces = os.networkInterfaces()
Object.keys(interfaces).forEach((key) =>
Expand Down