Skip to content

fix(create-app): improve prompt message #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 2 commits into from
Jun 12, 2021
Merged

fix(create-app): improve prompt message #3769

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d42ec
fix(create-app): improve prompt message
jamesgeorge007 Jun 11, 2021
89ef60a
test: update test suite
jamesgeorge007 Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: update test suite
  • Loading branch information
@jamesgeorge007
jamesgeorge007 committed Jun 12, 2021
commit 89ef60a6caf0e6b1b9baeaf7efa95e435c5b7e3e
5 changes: 5 additions & 0 deletions packages/create-app/__tests__/cli.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ test('prompts for the framework if none supplied', () => {
expect(stdout).toContain('Select a framework:')
})

test('prompts for the framework on not supplying a value for --template', () => {
const { stdout } = run([projectName, '--template'])
expect(stdout).toContain('Select a framework:')
})

test('prompts for the framework on supplying an invalid template', () => {
const { stdout } = run([projectName, '--template', 'unknown'])
expect(stdout).toContain(
Expand Down