Skip to content

fix: create-vite when targetDir is a valid packageName #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 3 commits into from
Jul 14, 2021
Merged

fix: create-vite when targetDir is a valid packageName #4247

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ede24f
fix: fix create-vite without packageName
spencer17x Jul 14, 2021
4a52bf8
Revert "fix: fix create-vite without packageName"
spencer17x Jul 14, 2021
c61f7c3
fix: fix create-vite without packageName
spencer17x Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fix: fix create-vite without packageName" 
This reverts commit 9ede24f.
  • Loading branch information
@spencer17x
spencer17x committed Jul 14, 2021
commit 4a52bf8638286188f70dd0ebffde57bc27093fd4
2 changes: 1 addition & 1 deletion packages/create-vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ async function init() {
name: 'overwriteChecker'
},
{
type: () => (isValidPackageName(targetDir) ? 'text' : null),
type: () => (isValidPackageName(targetDir) ? null : 'text'),
name: 'packageName',
message: 'Package name:',
initial: () => toValidPackageName(targetDir),
Expand Down