feat(create-vite): align template styles with docs#8478
Merged
Conversation
sapphi-red
reviewed
Jun 6, 2022
Member
sapphi-red
left a comment
There was a problem hiding this comment.
Cool ✨
Looks mostly good to me.
benmccann
reviewed
Jun 6, 2022
Collaborator
benmccann
left a comment
There was a problem hiding this comment.
maybe a create-svelte isn't a bad idea for example if it doesn't exist already
Just to share, we have a create-svelte which allows you to run npm init svelte in order to create a new SvelteKit project
Member
Author
|
@benmccann nice! Looks like it creates a SvelteKit app, we already have a link to the SvelteKit docs in the templates with a call to action to check them out. I think that is good for Svelte here then. |
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
Member
Author
sapphi-red
reviewed
Jun 7, 2022
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
previously approved these changes
Jun 7, 2022
tony19
reviewed
Jun 7, 2022
packages/create-vite/template-vue-ts/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
packages/create-vite/template-vue/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
tony19
reviewed
Jun 7, 2022
packages/create-vite/template-vue/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
packages/create-vite/template-vue-ts/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Tony Trinh <tony19@gmail.com>
Co-authored-by: Tony Trinh <tony19@gmail.com>
Co-authored-by: Tony Trinh <tony19@gmail.com>
Co-authored-by: Tony Trinh <tony19@gmail.com>
sapphi-red
approved these changes
Jun 7, 2022
tony19
approved these changes
Jun 7, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fix #8385
Hopefully, this will help to make it more clear to users that these templates are a way to try out Vite with their favorite framework, but these aren't production-grade scaffolding tools that include the recommended setup for testing, linting, etc from each framework. Like Vue has done with create-vue, we should push other frameworks to off a similar tool (most of them are already working in complete frameworks like SvelteKit, maybe a create-svelte isn't a bad idea for example if it doesn't exist already).
The new docs-aligned theme should also make the experience better when reading the docs and jumping to the online StackBlitz playgrounds.
Changes include:
What is the purpose of this pull request?