-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(vitest): add vi.advanceTimersToNextFrame
#6347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheremet-va
merged 2 commits into
vitest-dev:main
from
bnjm:feat-advance-timers-to-next-frame
Aug 15, 2024
Merged
feat(vitest): add vi.advanceTimersToNextFrame
#6347
sheremet-va
merged 2 commits into
vitest-dev:main
from
bnjm:feat-advance-timers-to-next-frame
Aug 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Very cool! Thank you for the shoutout ❤️ |
sheremet-va
previously approved these changes
Aug 15, 2024
sheremet-va
reviewed
Aug 15, 2024
Member
|
Thank you! |
6 tasks
This was referenced Oct 24, 2024
This was referenced Oct 25, 2024
This was referenced Oct 28, 2024
This was referenced Oct 30, 2024
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
vi.advanceTimersToNextFrame, using sinonjs/fake-timer'sclock.runToFrame()method, which Jest exposed asjest.advanceTimersToNextFrame()in this PR. Credit to @alexreardon for the feature implementation and tests there. I copied the test over exactly, as that seems to be the convention for other tests in the timers test suite.Resolves #6346
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.