test: fix flaky browser-multiple.test.ts #6977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Dec 6, 2024
| it('automatically assigns the port', async () => { | ||
| const root = resolve(import.meta.dirname, '../fixtures/browser-multiple') | ||
| const workspace = resolve(import.meta.dirname, '../fixtures/browser-multiple/vitest.workspace.ts') | ||
| const spy = vi.spyOn(console, 'log') |
Member
There was a problem hiding this comment.
We don't intercept Vite's logger with stdout, it's logged with console.log
with this change, if the behaviour breaks, this test won't fail
Contributor
Author
|
This looks fine now on Vite 6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing flaky test found in #6972 (comment). There are a few browser tests inside
test/cliand conflict of port63315happens (I can reproduce it locally).Not ideal, but for now I patched
ctx._browserLastPortas it still tests the same logic. Otherwise, we need to either setting different ports explicitly for all other tests or move out this test, but I wasn't sure how.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.