-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix (core): filter different projects in watch mode #7146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (core): filter different projects in watch mode #7146
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
f41276b to
057e610
Compare
0113ff3 to
bac2ef7
Compare
8030438 to
21c776b
Compare
DevJoaoLopes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed cache so we have the projects filtered properly.
I said "invalidate" the cache, not remove the if check |
okay, then I'll have to think about how to do that |
a72707e to
b2c2b32
Compare
@sheremet-va One of the ways to maintain this cache validation was to enter a condition to compare filtered projects by invalidating the cache when there are differences. |
DevJoaoLopes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert validation for cache condition
|
#7313 rewrote how workspaces are filtered which fixed this issue too. Still, thank you for your effort! |
Description
closes #7131
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.