fix: fix fetch cache multiple writes #7546

hi-ogawa · 2025-02-24T04:34:05Z

Description

Closes Race condition in test runner when using "define" in the vite configuration #6976

Trying the approach I mentioned in #7531 (comment)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2025-02-24T04:36:24Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`fc6b9fb`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/67bcfebad5a03b0008fd0626
😎 Deploy Preview	https://deploy-preview-7546--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new · 2025-02-24T04:37:26Z

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7546

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7546

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7546

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7546

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7546

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7546

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7546

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7546

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7546

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7546

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7546

vite-node

npm i https://pkg.pr.new/vite-node@7546

vitest

npm i https://pkg.pr.new/vitest@7546

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7546

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7546

commit: fc6b9fb

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | devDependencies | patch | [`3.0.7` -> `3.0.8`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/3.0.7/3.0.8) | | [vitest](https://github.com/vitest-dev/vitest) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | devDependencies | patch | [`3.0.7` -> `3.0.8`](https://renovatebot.com/diffs/npm/vitest/3.0.7/3.0.8) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@vitest/coverage-v8)</summary> ### [`v3.0.8`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.8) [Compare Source](vitest-dev/vitest@v3.0.7...v3.0.8) ##### 🐞 Bug Fixes - Fix fetch cache multiple writes - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7546 [<samp>(1a8b4)</samp>](vitest-dev/vitest@1a8b4337) - Use browser.isolate instead of config.isolate - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7560 [<samp>(4b5ed)</samp>](vitest-dev/vitest@4b5ed902) - Remove vestigial spy stub, import directly from `@vitest/spy` - by [@mrginglymus](https://github.com/mrginglymus) in vitest-dev/vitest#7575 [<samp>(7f7ff)</samp>](vitest-dev/vitest@7f7ff11c) - Correctly split the argv string - by [@btea](https://github.com/btea) in vitest-dev/vitest#7533 [<samp>(4325a)</samp>](vitest-dev/vitest@4325ac67) - **browser**: - Remove [@testing-library/dom](https://github.com/testing-library/dom) from dependencies - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7555 [<samp>(5387a)</samp>](vitest-dev/vitest@5387a5b3) - Improve source map handling for bundled files - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7534 [<samp>(e2c57)</samp>](vitest-dev/vitest@e2c570b6) - Print related test file and potential test in unhandled errors - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7564 [<samp>(fee90)</samp>](vitest-dev/vitest@fee90d85) - **runner**: - Fix `beforeEach/All` cleanup callback timeout - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7500 [<samp>(0c292)</samp>](vitest-dev/vitest@0c2924b7) - Fix and simplify `Task.suite` initialization - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7414 [<samp>(ca9ff)</samp>](vitest-dev/vitest@ca9ffac5) - **snapshot**: - Allow inline snapshot calls on same location with same snapshot - by [@jycouet](https://github.com/jycouet) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7464 [<samp>(d5cb8)</samp>](vitest-dev/vitest@d5cb8212) - **vite-node**: - Fix `buildStart` on Vite 6 - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7480 [<samp>(c0f47)</samp>](vitest-dev/vitest@c0f47e03) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.7...v3.0.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.justinelmore.dev/jelmore1674/build-changelog/pulls/95 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

fix: fix fetch cache multiple writes

7bb5a48

hi-ogawa added the cr-tracked label Feb 24, 2025

hi-ogawa marked this pull request as ready for review February 24, 2025 04:47

hi-ogawa mentioned this pull request Feb 24, 2025

fix: Race condition in RPC filesystem cache. #7531

Merged

6 tasks

sheremet-va approved these changes Feb 24, 2025

View reviewed changes

Merge branch 'main' into fix-fetch-cache-multiple-write

fc6b9fb

hi-ogawa merged commit 1a8b433 into vitest-dev:main Feb 24, 2025
14 checks passed

hi-ogawa deleted the fix-fetch-cache-multiple-write branch February 24, 2025 23:45

renovate bot mentioned this pull request Mar 6, 2025

chore(deps): update all non-major dependencies nuxt/scripts#266

Merged

1 task

maretol mentioned this pull request Mar 7, 2025

Bump the dependencies group across 3 directories with 5 updates maretol/maretol-base#349

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: fix fetch cache multiple writes #7546

fix: fix fetch cache multiple writes #7546

Uh oh!

hi-ogawa commented Feb 24, 2025 •

edited

Loading

Uh oh!

netlify bot commented Feb 24, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix: fix fetch cache multiple writes #7546

fix: fix fetch cache multiple writes #7546

Uh oh!

Conversation

hi-ogawa commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

pkg-pr-new bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hi-ogawa commented Feb 24, 2025 •

edited

Loading

netlify bot commented Feb 24, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 24, 2025 •

edited

Loading