fix: set diff.expand: false as default
#7697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Mar 19, 2025
- fixed `@vitest/browser` version mismatch - removed `--typecheck` since `tsc` catches same errors (and honestly vitest typecheck mode is not so intuitive 🙃) - added `diff.expand: false` since raw transfer mismatch is huge (we might change the default on Vitest side vitest-dev/vitest#7697)
sheremet-va
approved these changes
Mar 19, 2025
dammy001
approved these changes
Mar 25, 2025
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
diffoptions and supportprintBasicPrototype#6740I just saw a huge useless diff and remembered we didn't change the default yet. I'm not sure if we discussed about the default. Starting this PR to revive the discussion if we haven't.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.