map: use voidptr-based key equality and meta index methods#7320
Merged
Conversation
Add map::key_bytes field.
V currently does this automatically, but we shouldn't rely on it.
ntrel
changed the title
ntrel
commented
Dec 14, 2020
| meta += probe_inc | ||
| } | ||
| kv_index := m.key_values.push(key, value) | ||
| kv_index := m.key_values.push(&key, value) |
Contributor
Author
There was a problem hiding this comment.
This fixes a mistake from one of the DenseArray voidptr pulls. In practice this line change has no effect, because V automatically takes the address. I filed #7291 because I don't think it should.
ka-weihe
approved these changes
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6991.
Every operation on a map key needs to take a voidptr, not a string. This pull encapsulates:
Add map::key_bytes field.