-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Open
Labels
feature requestNew feature or requestNew feature or requeststaleOver 90 days of inactivityOver 90 days of inactivity
Description
🚀 The feature, motivation and pitch
Motivation
My understanding is that the KV events are mainly used to interface with the NVIDIA Dynamo framework, whose KvIndexer would always expect the external sequence hashes emitted by the engines to be consistent across backend engine processes. Therefore, it would probably make sense to always use SHA-256 hashing (or default to it) if the overhead is acceptable
Pitch
Always use SHA-256 hashing so the user does not need to set a fixed seed in the env var or set the --prefix-caching-algo sha256 flag, as done here, which would mean the flag would be deprecated as well.
Alternatives
No response
Additional context
No response
Before submitting a new issue...
- Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Metadata
Metadata
Assignees
Labels
feature requestNew feature or requestNew feature or requeststaleOver 90 days of inactivityOver 90 days of inactivity