Enhance plugin interface with timeout#3355
Enhance plugin interface with timeout#3355phuongatemc wants to merge 4 commits intovmware-tanzu:mainfrom
Conversation
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
jenting,
nrb and
zubron
dsu-igeek
added
the
kind/changelog-not-required
dsu-igeek
left a comment
dsu-igeek
left a comment
There was a problem hiding this comment.
Let's list out the APIs that will get contexts here. I think the list is
BackupItemAction.Execute
DeleteItemAction.Execute
ObjectStore.PutObject
ObjectStore.ObjectExists
ObjectStore.GetObject
ObjectStore.ListCommonPrefixes
ObjectStore.ListObjects
ObjectStore.DeleteObject
RestoreItemAction.Execute
VolumeSnapshotter.CreateVolumeFromSnapshot
VolumeSnapshotter.GetVolumeInfo
VolumeSnapshotter.CreateSnapshot
VolumeSnapshotter.DeleteSnapshot
Do you want me to add this list to the design doc itself? |
Signed-off-by: Hoang, Phuong <phuong.hoang@emc.com>
|
@dsu-igeek I have added the list of new functions. |
|
This is blocked on #3285 |
4 participants
Adding context object to the functions of the Velero plugin. This context object can be used to set timeout for the operation by the caller. To ensure backward compatibility and avoid forcing all plugin vendor upgrade their code in lock-step, a new interface would be created to wrap around the existing interface and new functions would be created with additional parameter ctx context.Context as the first parameter. The plugin vendor can decide to implement new function (with context) or keep using existing one.