Skip to content

Conversation

@danfengliu
Copy link
Contributor

@danfengliu danfengliu commented Mar 7, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5870

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@danfengliu danfengliu added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Mar 7, 2023
@github-actions github-actions bot requested review from blackpiglet and sseago March 7, 2023 08:48
@danfengliu danfengliu force-pushed the add-params-for-upgrade-e2e-tests branch from 7639086 to 7257588 Compare March 7, 2023 08:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #5962 (48dd2ba) into main (8bed159) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5962   +/-   ##
=======================================
  Coverage   39.76%   39.76%           
=======================================
  Files         256      256           
  Lines       23236    23236           
=======================================
  Hits         9239     9239           
  Misses      13299    13299           
  Partials      698      698           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danfengliu danfengliu force-pushed the add-params-for-upgrade-e2e-tests branch from 7257588 to 4f977b0 Compare March 7, 2023 09:30
@danfengliu danfengliu force-pushed the add-params-for-upgrade-e2e-tests branch from 4f977b0 to 48dd2ba Compare March 7, 2023 09:36
@danfengliu danfengliu changed the title Remove subscriptionId and resourceGroup from Azure BSL [OnHold] Remove subscriptionId and resourceGroup from Azure BSL Mar 15, 2023
@danfengliu danfengliu marked this pull request as draft May 5, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the "subscriptionId" and "resourceGroup" items from the BSL config when installing Velero in E2E test

3 participants