Skip to content

Conversation

@blackpiglet
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Mar 27, 2023
@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 2 times, most recently from a38d635 to ab43940 Compare March 27, 2023 13:58
@blackpiglet
Copy link
Contributor Author

blackpiglet commented Mar 27, 2023

Still cannot workaround the VSC error without adding the -buildvcs=falseflag into the code-generator's script.

error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.

I created an issue in the code-generator repository to ask for some help.
https://github.com/kubernetes/code-generator/issues/156

The sed command is removed, by checkout code-generator git repository in the update CRD script.

@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 3 times, most recently from a1ee7a5 to 007f8b2 Compare March 31, 2023 06:46
@blackpiglet blackpiglet marked this pull request as ready for review March 31, 2023 06:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #6039 (42ec721) into main (491664e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6039   +/-   ##
=======================================
  Coverage   41.32%   41.32%           
=======================================
  Files         251      251           
  Lines       23375    23375           
=======================================
  Hits         9660     9660           
  Misses      12957    12957           
  Partials      758      758           
Impacted Files Coverage Δ
pkg/cmd/server/server.go 5.19% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Lyndon-Li
Lyndon-Li previously approved these changes Mar 31, 2023
reasonerjt
reasonerjt previously approved these changes Apr 3, 2023
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackpiglet blackpiglet dismissed stale reviews from reasonerjt and Lyndon-Li via 2771b4b April 4, 2023 02:39
@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 4 times, most recently from 277c976 to 771c345 Compare April 4, 2023 03:48
@blackpiglet blackpiglet force-pushed the update_golang_version_new branch 5 times, most recently from 7cf6285 to 4dbffa4 Compare April 4, 2023 04:26
Signed-off-by: Xun Jiang/Bruce Jiang <[email protected]>
Signed-off-by: Xun Jiang <[email protected]>
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Sep 11, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Sep 12, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Sep 12, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Sep 30, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 11, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 16, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 18, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 23, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 25, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 28, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Oct 29, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 1, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 1, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 4, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 6, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 8, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 11, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 13, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 20, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 22, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 25, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 27, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Nov 29, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 4, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 6, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 9, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 11, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 13, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 20, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
oadp-rebasebot-cloner bot pushed a commit to oadp-rebasebot/velero that referenced this pull request Dec 23, 2025
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants