Skip to content

do not attempt to run hooks on Pods that aren't running #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
haslersn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

do not attempt to run hooks on Pods that aren't running #6811

haslersn wants to merge 2 commits into from

Conversation

@haslersn
Copy link

@haslersn haslersn commented Sep 12, 2023 •
edited
Loading

Skip Pod hooks when the Pod's phase isn't Running.

Replaces #5211
Fixes #5137

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@haslersn haslersn force-pushed the fix-5137 branch 3 times, most recently from 1165010 to 3d262cb Compare September 12, 2023 18:09
@kaovilai
Copy link
Collaborator

kaovilai commented Sep 12, 2023

We might want to skip on completed or failed pods but if pod is not yet running due to it being very new velero should wait a bit.

@haslersn
Copy link
Author

haslersn commented Sep 12, 2023

if pod is not yet running due to it being very new velero should wait a bit.

Currently Velero doesn't wait either, so changing that behavior is a separate issue that can be done in a separate PR.

@haslersn
Copy link
Author

haslersn commented Sep 12, 2023

Though maybe we should return an error when the Pod is Pending (and also when the Pod is Failed?), so the hook isn't silently skipped.

@haslersn
Copy link
Author

haslersn commented Sep 12, 2023

maybe we should return an error when the Pod is Pending (and also when the Pod is Failed?)

I just implemented this, PTAL.

@haslersn haslersn force-pushed the fix-5137 branch 2 times, most recently from 07c7628 to 16f989f Compare September 12, 2023 19:10
kaovilai
kaovilai reviewed Sep 12, 2023
View reviewed changes
@haslersn haslersn mentioned this pull request Sep 13, 2023
Merged
3 tasks
haslersn and others added 2 commits September 13, 2023 09:36
@haslersn
Revert "check pod status before hook (vmware-tanzu#5211)"
1728828 
This reverts commit 9b1cffc.
@haslersn
do not attempt to run hooks on Pods that aren't running
3a7788b 
Skip Pod hooks when the Pod's phase isn't Running.

Fixes vmware-tanzu#5137

Signed-off-by: Sebastian Hasler <[email protected]>
kaovilai
kaovilai reviewed Sep 14, 2023
View reviewed changes
changelogs/unreleased/5211-cleverhu
@@ -1 +0,0 @@
fix run preHook and postHook on completed pods No newline at end of file
Copy link
Collaborator

@kaovilai kaovilai Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this changelog meant to be deleted completely rather than a single line?

Copy link
Author

@haslersn haslersn Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is deleted in the commit.

Copy link
Collaborator

@kaovilai kaovilai Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaovilai kaovilai kaovilai left review comments

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

@ywk253100 ywk253100 Awaiting requested review from ywk253100

At least 2 approving reviews are required to merge this pull request.

Assignees

@haslersn haslersn

Labels

Documentation has-changelog has-unit-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Velero tries to run preHook and postHook on Completed Pods

2 participants

@haslersn @kaovilai