Skip to content

Fix vsc backup plugin progress method to not fail on temporary errors #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shubham-pampattiwar wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix vsc backup plugin progress method to not fail on temporary errors #8023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/backup/actions/csi/volumesnapshot_action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,12 +346,13 @@ func (p *volumeSnapshotBackupItemAction) Progress(
progress.Completed = true
progress.Updated = now
} else if vsc.Status.Error != nil {
progress.Completed = true
progress.Updated = now
errorMessage := ""
if vsc.Status.Error.Message != nil {
progress.Err = *vsc.Status.Error.Message
errorMessage = *vsc.Status.Error.Message
}
p.log.Warnf("VolumeSnapshotContent meets an error %s.", progress.Err)
p.log.Warnf("VolumeSnapshotContent has a temporary error %s. SnapshotContent controller will retry later.",
errorMessage)
return progress, nil
}
}

Expand Down