Issue 8433: add third party labels to data mover pods when the same labels exist in node-agent pods #8487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
force-pushed
the
issue-fix-8433-data-mover-pod-label-for-aks
branch
from
25d2a1d to
9af57ab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8487 +/- ##
==========================================
+ Coverage 59.02% 59.04% +0.01%
==========================================
Files 369 369
Lines 39056 39104 +48
==========================================
+ Hits 23052 23088 +36
- Misses 14542 14553 +11
- Partials 1462 1463 +1 ☔ View full report in Codecov by Sentry. |
sseago
previously approved these changes
Dec 5, 2024
Lyndon-Li
changed the title
kaovilai
requested changes
Dec 5, 2024
ywk253100
reviewed
Dec 6, 2024
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
issue-fix-8433-data-mover-pod-label-for-aks
branch
from
9af57ab to
d914702
Compare
sseago
previously approved these changes
Dec 6, 2024
shubham-pampattiwar
previously approved these changes
Dec 6, 2024
kaovilai
previously approved these changes
Dec 6, 2024
Lyndon-Li
changed the title
Lyndon-Li
dismissed stale reviews from kaovilai, shubham-pampattiwar, and sseago
via
26d6107
Lyndon-Li
force-pushed
the
issue-fix-8433-data-mover-pod-label-for-aks
branch
from
487337c to
26d6107
Compare
blackpiglet
previously approved these changes
Dec 9, 2024
ywk253100
reviewed
Dec 9, 2024
Lyndon-Li
force-pushed
the
issue-fix-8433-data-mover-pod-label-for-aks
branch
from
26d6107 to
04cc78d
Compare
Lyndon-Li
force-pushed
the
issue-fix-8433-data-mover-pod-label-for-aks
branch
from
04cc78d to
443e360
Compare
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
issue-fix-8433-data-mover-pod-label-for-aks
branch
from
443e360 to
3ce6838
Compare
ywk253100
approved these changes
Dec 9, 2024
sseago
approved these changes
Dec 9, 2024
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
…abels exist in node-agent pods (vmware-tanzu#8487) * issue 8433: add ask label to data mover pods Signed-off-by: Lyndon-Li <[email protected]> * check existence of the same label from node-agent Signed-off-by: Lyndon-Li <[email protected]> --------- Signed-off-by: Lyndon-Li <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #8433, add third party labels to data mover pods when the same labels exist in node-agent pods