Add profiler address parameter on node-agent #8618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobKenis
force-pushed
the
feature/node-agent-profiler
branch
from
cc443f2 to
62620ba
Compare
kaovilai
previously approved these changes
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8618 +/- ##
==========================================
- Coverage 60.06% 60.03% -0.03%
==========================================
Files 378 378
Lines 42883 42903 +20
==========================================
Hits 25757 25757
- Misses 15580 15600 +20
Partials 1546 1546 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@RobKenis Thanks for the PR, this change looks good to me. Would you mind adding a changelog to the PR? |
reasonerjt
requested review from
Lyndon-Li
and removed request for
blackpiglet and
reasonerjt
This allows us to enable the profiler endpoints on both the server and the node agent. This helps me in troubleshooting the high memory usage when restoring lots of small files. Refs: vmware-tanzu#8582 Signed-off-by: Rob Kenis <[email protected]>
RobKenis
force-pushed
the
feature/node-agent-profiler
branch
from
62620ba to
6cb6b48
Compare
Author
|
@reasonerjt I have added a changelog. The codecov fails, but I don't really see the solution to write tests on the profiler. For the velero server component, I cannot find any related tests to the profiler |
kaovilai
approved these changes
Jul 16, 2025
Comment on lines
+412
to
+414
| if err := server.ListenAndServe(); err != nil { | ||
| s.logger.WithError(errors.WithStack(err)).Error("error running profiler http server") | ||
| } |
Collaborator
There was a problem hiding this comment.
There's no graceful shutdown of the profiler server when s.ctx is cancelled., tho the same can be said about current metrics server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to enable the profiler endpoints on both the server and the node agent.
This helps me in troubleshooting the high memory usage when restoring lots of small files.
Refs: #8582
Thank you for contributing to Velero!
Please add a summary of your change
Add
--profiler-addressoption to node agentDoes your change fix a particular issue?
No. But this helps me in understanding #8582
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.