Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 22, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Bump golangci-lint from v1.57.2 to v1.64.5 and fixes newly identified issues

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.53%. Comparing base (3821906) to head (2201a23).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/storage/storagelocation.go 0.00% 1 Missing ⚠️
pkg/cmd/util/downloadrequest/downloadrequest.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8641   +/-   ##
=======================================
  Coverage   59.53%   59.53%           
=======================================
  Files         371      371           
  Lines       40196    40196           
=======================================
  Hits        23932    23932           
  Misses      14767    14767           
  Partials     1497     1497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 22, 2025
@mmorel-35 mmorel-35 changed the title Bump golangci-lint from v1.57.2 to v1.63.4 Bump golangci-lint from v1.57.2 to v1.64.5 Feb 21, 2025
@mmorel-35
Copy link
Contributor Author

/cc @kaovilai , @blackpiglet ,
Would you mind having a look whenever you can find the time ?

@github-actions github-actions bot requested a review from kaovilai March 3, 2025 21:36
@anshulahuja98 anshulahuja98 merged commit 6a6a237 into vmware-tanzu:main Mar 4, 2025
42 checks passed
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants