Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 8, 2025

Thank you for contributing to Velero!

Please add a summary of your change

define common aliases for k8s packages

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 8, 2025
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 83.92857% with 54 lines in your changes missing coverage. Please review.

Project coverage is 59.56%. Comparing base (f0fde6e) to head (341093a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/cli/nodeagent/server.go 14.28% 6 Missing ⚠️
pkg/datapath/micro_service_watcher.go 53.84% 6 Missing ⚠️
pkg/exposer/csi_snapshot.go 85.71% 6 Missing ⚠️
pkg/exposer/generic_restore.go 80.00% 6 Missing ⚠️
pkg/restore/restore.go 79.16% 4 Missing and 1 partial ⚠️
pkg/controller/data_upload_controller.go 70.00% 2 Missing and 1 partial ⚠️
pkg/controller/restore_finalizer_controller.go 62.50% 0 Missing and 3 partials ⚠️
pkg/cmd/cli/datamover/backup.go 0.00% 2 Missing ⚠️
pkg/cmd/cli/datamover/restore.go 0.00% 2 Missing ⚠️
pkg/cmd/cli/restore/create.go 33.33% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8672   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         370      370           
  Lines       40246    40246           
=======================================
  Hits        23973    23973           
  Misses      14773    14773           
  Partials     1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch from 607a313 to 77f6ec6 Compare February 8, 2025 11:30
blackpiglet
blackpiglet previously approved these changes Feb 10, 2025
kaovilai
kaovilai previously approved these changes Feb 10, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch from 77f6ec6 to 6d8991c Compare February 11, 2025 07:16
@mmorel-35 mmorel-35 dismissed stale reviews from blackpiglet and kaovilai via 294aeab February 19, 2025 19:08
@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch from 6d8991c to 294aeab Compare February 19, 2025 19:08
kaovilai
kaovilai previously approved these changes Feb 21, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch 5 times, most recently from 407eb5b to 6e40d16 Compare March 4, 2025 09:08
kaovilai
kaovilai previously approved these changes Mar 4, 2025
@mmorel-35
Copy link
Contributor Author

@blackpiglet ,
You already accepted last month anything blocking merging ?

@blackpiglet
Copy link
Contributor

Could we wait for the release-1.16 branch cut?

@mmorel-35
Copy link
Contributor Author

That's fine for me !
When is it going to happen ?

@blackpiglet
Copy link
Contributor

That's fine for me ! When is it going to happen ?

The target date is the early stage of this April.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch 4 times, most recently from 3439db0 to 19836e4 Compare March 17, 2025 07:11
@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch 2 times, most recently from 89f3c35 to 1412f68 Compare March 26, 2025 18:11
kaovilai
kaovilai previously approved these changes Mar 26, 2025
blackpiglet
blackpiglet previously approved these changes Apr 14, 2025
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
@kaovilai kaovilai merged commit c6a420b into vmware-tanzu:main Apr 22, 2025
42 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/importas branch April 22, 2025 11:48
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
* lchore: define common alias for k8s packages

Signed-off-by: Matthieu MOREL <[email protected]>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <[email protected]>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <[email protected]>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <[email protected]>

---------

Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants