Add labels as a criteria for volume policy #8713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
06b2e5d to
62a0d5e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8713 +/- ##
==========================================
+ Coverage 59.51% 59.53% +0.02%
==========================================
Files 371 371
Lines 40179 40191 +12
==========================================
+ Hits 23911 23927 +16
+ Misses 14775 14767 -8
- Partials 1493 1497 +4 ☔ View full report in Codecov by Sentry. |
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
62a0d5e to
0060579
Compare
kaovilai
previously approved these changes
Feb 20, 2025
Collaborator
kaovilai
left a comment
kaovilai
left a comment
There was a problem hiding this comment.
lgtm. This matches the current design.
sseago
previously approved these changes
Feb 20, 2025
shubham-pampattiwar
dismissed stale reviews from sseago and kaovilai
via
c217ad6
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
0060579 to
c217ad6
Compare
kaovilai
previously approved these changes
Feb 20, 2025
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
c217ad6 to
687342d
Compare
sseago
previously approved these changes
Feb 20, 2025
kaovilai
previously approved these changes
Feb 20, 2025
Lyndon-Li
reviewed
Feb 21, 2025
shubham-pampattiwar
dismissed stale reviews from kaovilai and sseago
via
487f9fc
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
687342d to
487f9fc
Compare
Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> handle err Signed-off-by: Shubham Pampattiwar <[email protected]> use labels selector.matches Signed-off-by: Shubham Pampattiwar <[email protected]> make update Signed-off-by: Shubham Pampattiwar <[email protected]> remove fetching pvc from volume policy filtering Signed-off-by: Shubham Pampattiwar <[email protected]> add more ut coverage Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
487f9fc to
e6493fc
Compare
sseago
reviewed
Feb 21, 2025
Collaborator
sseago
left a comment
sseago
left a comment
There was a problem hiding this comment.
I think this is going in the right direction, but a couple of suggestions in my review comments.
sseago
previously approved these changes
Feb 22, 2025
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
1801a42 to
085e5f7
Compare
Lyndon-Li
reviewed
Feb 26, 2025
Lyndon-Li
reviewed
Feb 26, 2025
Lyndon-Li
reviewed
Feb 26, 2025
Contributor
|
@shubham-pampattiwar Some minor changes suggested, please have another look. Thanks! |
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
085e5f7 to
dd5249c
Compare
Signed-off-by: Shubham Pampattiwar <[email protected]> use VolumeFilterData struct in GetMatchAction func Signed-off-by: Shubham Pampattiwar <[email protected]> update parsePVC func and add more ut Signed-off-by: Shubham Pampattiwar <[email protected]> lint fix Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
vp-impl-label-criteria
branch
from
dd5249c to
f756a6d
Compare
Lyndon-Li
approved these changes
Feb 26, 2025
blackpiglet
approved these changes
Feb 26, 2025
sseago
approved these changes
Feb 26, 2025
3 tasks
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
* Add labels as a criteria for volume policy Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> handle err Signed-off-by: Shubham Pampattiwar <[email protected]> use labels selector.matches Signed-off-by: Shubham Pampattiwar <[email protected]> make update Signed-off-by: Shubham Pampattiwar <[email protected]> remove fetching pvc from volume policy filtering Signed-off-by: Shubham Pampattiwar <[email protected]> add more ut coverage Signed-off-by: Shubham Pampattiwar <[email protected]> * minor updates Signed-off-by: Shubham Pampattiwar <[email protected]> use VolumeFilterData struct in GetMatchAction func Signed-off-by: Shubham Pampattiwar <[email protected]> update parsePVC func and add more ut Signed-off-by: Shubham Pampattiwar <[email protected]> lint fix Signed-off-by: Shubham Pampattiwar <[email protected]> --------- Signed-off-by: Shubham Pampattiwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Implementation for design #8503
Does your change fix a particular issue?
Fixes #8256
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.