Skip to content

Conversation

@hu-keyu
Copy link
Contributor

@hu-keyu hu-keyu commented Feb 25, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Make compatible changes based on the GetVolumeSnapshotClassForStorageClass method,not break existing behaviour.

Does your change fix a particular issue?

Fixes #8294

Please indicate you've done the following:

@hu-keyu
Copy link
Contributor Author

hu-keyu commented Feb 25, 2025

review comments on PR 8719 has resovled,submit a new PR.

please reivew this PR @anshulahuja98

@hu-keyu
Copy link
Contributor Author

hu-keyu commented Feb 25, 2025

please review PR #8721 , thanks

kaovilai
kaovilai previously approved these changes Feb 25, 2025
@kaovilai
Copy link
Collaborator

kaovilai commented Feb 25, 2025

@hu-keyu this might not merge until 1.16 release is cut FYI.
Also please fix your DCO
.

@anshulahuja98
Copy link
Collaborator

anshulahuja98 commented Feb 26, 2025

@hu-keyu can you add this in the website docs also ?
On the page where we talk about user to put the label, we should tell them that they could also apply the annotation on VSClass.

@hu-keyu
Copy link
Contributor Author

hu-keyu commented Feb 26, 2025

Which file should I add it to? @anshulahuja98

@anshulahuja98
Copy link
Collaborator

@anshulahuja98
Copy link
Collaborator

PR LGTM, CI is running currently.
We will merge this once 1.16 branch is cut. Holding onto PR Approval till then.
Thank you for your contribution @hu-keyu

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.44%. Comparing base (0f81772) to head (1d08b46).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/csi/volume_snapshot.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8721      +/-   ##
==========================================
+ Coverage   59.48%   60.44%   +0.95%     
==========================================
  Files         371      372       +1     
  Lines       40191    41239    +1048     
==========================================
+ Hits        23909    24925    +1016     
- Misses      14789    14810      +21     
- Partials     1493     1504      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hu-keyu
Copy link
Contributor Author

hu-keyu commented Mar 31, 2025

PR LGTM, CI is running currently. We will merge this once 1.16 branch is cut. Holding onto PR Approval till then. Thank you for your contribution @hu-keyu

PR LGTM, CI is running currently. We will merge this once 1.16 branch is cut. Holding onto PR Approval till then. Thank you for your contribution @hu-keyu

@hu-keyu hu-keyu closed this Mar 31, 2025
@hu-keyu
Copy link
Contributor Author

hu-keyu commented Mar 31, 2025

PR LGTM, CI is running currently. We will merge this once 1.16 branch is cut. Holding onto PR Approval till then. Thank you for your contribution @hu-keyu

Can this PR be merged? @anshulahuja98

@hu-keyu hu-keyu reopened this Mar 31, 2025
@github-actions github-actions bot requested a review from ywk253100 March 31, 2025 09:25
@anshulahuja98 anshulahuja98 merged commit 5160f96 into vmware-tanzu:main Apr 7, 2025
85 checks passed
hu-keyu added a commit to hu-keyu/velero that referenced this pull request Apr 9, 2025
* inherit k8s default volumeSnapshotClass

Signed-off-by: hu-keyu <[email protected]>

* add doc change for issue8294

Signed-off-by: hu-keyu <[email protected]>

---------

Signed-off-by: hu-keyu <[email protected]>
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
* inherit k8s default volumeSnapshotClass

Signed-off-by: hu-keyu <[email protected]>

* add doc change for issue8294

Signed-off-by: hu-keyu <[email protected]>

---------

Signed-off-by: hu-keyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect the "snapshot.storage.kubernetes.io/is-default-class: true" annotation of VolumeSnapshotClass when taking the CSI snapshot

4 participants