-
Notifications
You must be signed in to change notification settings - Fork 1.5k
issue8294: inherit k8s default volumeSnapshotClass #8721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
review comments on PR 8719 has resovled,submit a new PR. please reivew this PR @anshulahuja98 |
|
please review PR #8721 , thanks |
|
@hu-keyu can you add this in the website docs also ? |
|
Which file should I add it to? @anshulahuja98 |
Signed-off-by: hu-keyu <[email protected]>
Signed-off-by: hu-keyu <[email protected]>
|
PR LGTM, CI is running currently. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8721 +/- ##
==========================================
+ Coverage 59.48% 60.44% +0.95%
==========================================
Files 371 372 +1
Lines 40191 41239 +1048
==========================================
+ Hits 23909 24925 +1016
- Misses 14789 14810 +21
- Partials 1493 1504 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can this PR be merged? @anshulahuja98 |
* inherit k8s default volumeSnapshotClass Signed-off-by: hu-keyu <[email protected]> * add doc change for issue8294 Signed-off-by: hu-keyu <[email protected]> --------- Signed-off-by: hu-keyu <[email protected]>
* inherit k8s default volumeSnapshotClass Signed-off-by: hu-keyu <[email protected]> * add doc change for issue8294 Signed-off-by: hu-keyu <[email protected]> --------- Signed-off-by: hu-keyu <[email protected]>
Thank you for contributing to Velero!
Please add a summary of your change
Make compatible changes based on the GetVolumeSnapshotClassForStorageClass method,not break existing behaviour.
Does your change fix a particular issue?
Fixes #8294
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.