Skip to content

Conversation

@Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Mar 25, 2025

Add third party annotation support for maintenance job, so that the declared third party annotations could be added to the maintenance job pods.

Otherwise, there is the same problem for maintenance jobs as #8754 for data movers.

@Lyndon-Li Lyndon-Li force-pushed the third-party-annotation-for-maintenance-job branch from 213119b to f1dcb7b Compare March 25, 2025 05:43
@Lyndon-Li Lyndon-Li marked this pull request as ready for review March 25, 2025 05:54
@Lyndon-Li Lyndon-Li requested a review from ywk253100 March 25, 2025 05:55
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.56%. Comparing base (883e3e4) to head (f1dcb7b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/velero/velero.go 0.00% 5 Missing ⚠️
pkg/repository/maintenance/maintenance.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8812      +/-   ##
==========================================
- Coverage   59.57%   59.56%   -0.01%     
==========================================
  Files         370      370              
  Lines       40228    40239      +11     
==========================================
+ Hits        23966    23969       +3     
- Misses      14764    14771       +7     
- Partials     1498     1499       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +464 to +468
for _, k := range util.ThirdPartyAnnotations {
if v := veleroutil.GetVeleroServerAnnotationValue(deployment, k); v != "" {
podAnnotations[k] = v
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current list of "well known annotations" only include aws.

var ThirdPartyAnnotations = []string{
"iam.amazonaws.com/role",
}

Do we need to add more to really address #8811?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it as far as I understand.
The problem happens just because the maintenance pod has inherited some labels/annotations from Velero server pod. While in a previous PR, we have changed the code not to inherit any labels/annotations from it, so the problem should have been fixed.

@Lyndon-Li Lyndon-Li requested a review from kaovilai March 26, 2025 05:21
@Lyndon-Li Lyndon-Li merged commit 751d782 into vmware-tanzu:main Mar 26, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants