-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add third party annotation support for maintenance job #8812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add third party annotation support for maintenance job #8812
Conversation
Signed-off-by: Lyndon-Li <[email protected]>
213119b to
f1dcb7b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8812 +/- ##
==========================================
- Coverage 59.57% 59.56% -0.01%
==========================================
Files 370 370
Lines 40228 40239 +11
==========================================
+ Hits 23966 23969 +3
- Misses 14764 14771 +7
- Partials 1498 1499 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| for _, k := range util.ThirdPartyAnnotations { | ||
| if v := veleroutil.GetVeleroServerAnnotationValue(deployment, k); v != "" { | ||
| podAnnotations[k] = v | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current list of "well known annotations" only include aws.
velero/pkg/util/third_party.go
Lines 23 to 25 in 883e3e4
| var ThirdPartyAnnotations = []string{ | |
| "iam.amazonaws.com/role", | |
| } |
Do we need to add more to really address #8811?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need it as far as I understand.
The problem happens just because the maintenance pod has inherited some labels/annotations from Velero server pod. While in a previous PR, we have changed the code not to inherit any labels/annotations from it, so the problem should have been fixed.
Add third party annotation support for maintenance job, so that the declared third party annotations could be added to the maintenance job pods.
Otherwise, there is the same problem for maintenance jobs as #8754 for data movers.