-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Propagate dns settings to backup pods #8845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Felix Prasse <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8845 +/- ##
==========================================
- Coverage 59.56% 59.55% -0.02%
==========================================
Files 370 370
Lines 40239 40253 +14
==========================================
+ Hits 23969 23972 +3
- Misses 14771 14780 +9
- Partials 1499 1501 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Felix Prasse <[email protected]>
kaovilai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed this change and it looks good. The approach to propagate DNS settings (dnsPolicy and dnsConfig) from the node agent pod to backup pods aligns well with Kubernetes best practices.
This will ensure consistent DNS resolution behavior between the node agent and the backup pods, which is critical when custom DNS settings are needed to reach storage endpoints like S3.
References from Kubernetes docs:
- https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy
- https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-config
LGTM 👍
| dnsPolicy v1.DNSPolicy | ||
| dnsConfig *v1.PodDNSConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#8887
Fixes issue introduced here + the common alias pr.
* Propagate dns settings to backup pods Signed-off-by: Felix Prasse <[email protected]> * Add changelog for PR 8845 Signed-off-by: Felix Prasse <[email protected]> --------- Signed-off-by: Felix Prasse <[email protected]>
The dnsPolicy and dnsConfig field of the node-agent should be inherited. Otherwise a S3 server that is only available by using the indicated dns server will be unreachable in the upload pod.
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.