Skip to content

Conversation

@flx5
Copy link
Contributor

@flx5 flx5 commented Apr 6, 2025

The dnsPolicy and dnsConfig field of the node-agent should be inherited. Otherwise a S3 server that is only available by using the indicated dns server will be unreachable in the upload pod.

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.55%. Comparing base (8934b2c) to head (8aac1da).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8845      +/-   ##
==========================================
- Coverage   59.56%   59.55%   -0.02%     
==========================================
  Files         370      370              
  Lines       40239    40253      +14     
==========================================
+ Hits        23969    23972       +3     
- Misses      14771    14780       +9     
- Partials     1499     1501       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lyndon-Li
Lyndon-Li previously approved these changes Apr 7, 2025
@anshulahuja98 anshulahuja98 removed their request for review April 7, 2025 06:48
Signed-off-by: Felix Prasse <[email protected]>
Copy link
Collaborator

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this change and it looks good. The approach to propagate DNS settings (dnsPolicy and dnsConfig) from the node agent pod to backup pods aligns well with Kubernetes best practices.

This will ensure consistent DNS resolution behavior between the node agent and the backup pods, which is critical when custom DNS settings are needed to reach storage endpoints like S3.

References from Kubernetes docs:

LGTM 👍

@kaovilai kaovilai enabled auto-merge (squash) April 25, 2025 02:45
@kaovilai kaovilai merged commit 1589439 into vmware-tanzu:main Apr 25, 2025
44 checks passed
Comment on lines +39 to +40
dnsPolicy v1.DNSPolicy
dnsConfig *v1.PodDNSConfig
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8887
Fixes issue introduced here + the common alias pr.

@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
* Propagate dns settings to backup pods

Signed-off-by: Felix Prasse <[email protected]>

* Add changelog for PR 8845

Signed-off-by: Felix Prasse <[email protected]>

---------

Signed-off-by: Felix Prasse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants