-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Extend PVCAction itemblock plugin to support grouping PVCs under VGS label key #8944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend PVCAction itemblock plugin to support grouping PVCs under VGS label key #8944
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8944 +/- ##
==========================================
+ Coverage 59.81% 59.84% +0.02%
==========================================
Files 375 375
Lines 41056 41100 +44
==========================================
+ Hits 24557 24595 +38
- Misses 15010 15014 +4
- Partials 1489 1491 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
74b18b8 to
f23f3b9
Compare
Code Review Summary ✅Great work on implementing VGS support in the PVC ItemBlockAction plugin! This is a solid implementation that addresses issue #8935 requirements. Overall Assessment:
Key Strengths:
Minor Enhancement Opportunities (within PR scope):I've added specific code review comments for:
Test Coverage:The test suite is comprehensive. Consider adding one more edge case for empty group values to complete the coverage. Looking forward to seeing this land! 🚀 |
f23f3b9 to
8310994
Compare
|
@sseago Addressed #8938 (review) in this PR ! |
kaovilai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8310994 to
0084e4a
Compare
0084e4a to
dafaf70
Compare
6769c6c to
3fa9280
Compare
3fa9280 to
aee5132
Compare
aee5132 to
1ff8500
Compare
…meGroupSnapshot label Signed-off-by: Shubham Pampattiwar <[email protected]> Add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> Update VGS label key and address PR feedback Signed-off-by: Shubham Pampattiwar <[email protected]> update log level to debug for edge cases Signed-off-by: Shubham Pampattiwar <[email protected]> Change VGS label key constant location Signed-off-by: Shubham Pampattiwar <[email protected]> run make update Signed-off-by: Shubham Pampattiwar <[email protected]>
1ff8500 to
97a4d62
Compare
|
@Lyndon-Li @blackpiglet @kaovilai PR review request ! |
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8935
Related to sub-task of #8865
Depends on merging #8938Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.