Remove username/password credential handling from newConfigCredential #9041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Priyansh Choudhary <[email protected]>
priyansh17
force-pushed
the
issue-#9028/removePasswordAuth
branch
from
828ae9c to
779727e
Compare
Signed-off-by: Priyansh Choudhary <[email protected]>
priyansh17
force-pushed
the
issue-#9028/removePasswordAuth
branch
from
df3be77 to
5ec364e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9041 +/- ##
==========================================
- Coverage 60.30% 60.29% -0.01%
==========================================
Files 378 378
Lines 42746 42737 -9
==========================================
- Hits 25777 25769 -8
+ Misses 15419 15418 -1
Partials 1550 1550 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anshulahuja98
requested review from
Lyndon-Li,
blackpiglet and
ywk253100
and removed request for
blackpiglet and
sseago
anshulahuja98
approved these changes
Jun 25, 2025
kaovilai
approved these changes
Jun 27, 2025
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
…vmware-tanzu#9041) * remove username/password credential handling from newConfigCredential Signed-off-by: Priyansh Choudhary <[email protected]> * changelog update Signed-off-by: Priyansh Choudhary <[email protected]> * remove username/password credential tests from newConfigCredential. Signed-off-by: Priyansh Choudhary <[email protected]> --------- Signed-off-by: Priyansh Choudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azidentity.UsernamePasswordCredentialOptions is reported as deprecated
Hence we need to remove the username/password credential handling from newConfigCredential function.
Does your change fix a particular issue?
Linter check error
Fixes #(issue)
#9028
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.