Add support for image registry proxy in Kibishii installation #9063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9063 +/- ##
==========================================
- Coverage 60.06% 60.05% -0.01%
==========================================
Files 378 378
Lines 42883 42883
==========================================
- Hits 25757 25754 -3
- Misses 15580 15582 +2
- Partials 1546 1547 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
blackpiglet
added
the
kind/changelog-not-required
blackpiglet
force-pushed
the
add-support-for-kibishiImageWithRegistry
branch
from
8d05df9 to
31b2477
Compare
blackpiglet
previously approved these changes
Jul 4, 2025
Contributor
|
@priyansh17 Thanks for this PR. |
kaovilai
reviewed
Jul 8, 2025
blackpiglet
force-pushed
the
add-support-for-kibishiImageWithRegistry
branch
from
fb1b97a to
e1cddf6
Compare
Signed-off-by: Priyansh Choudhary <[email protected]>
…ne handling of image registry proxy Signed-off-by: Priyansh Choudhary <[email protected]>
…ays folder is used Signed-off-by: Priyansh Choudhary <[email protected]>
…move overlays path from image patching Signed-off-by: Priyansh Choudhary <[email protected]>
blackpiglet
force-pushed
the
add-support-for-kibishiImageWithRegistry
branch
from
e1cddf6 to
338a337
Compare
…esource closure Signed-off-by: Priyansh Choudhary <[email protected]>
Signed-off-by: Priyansh Choudhary <[email protected]>
kaovilai
approved these changes
Jul 14, 2025
blackpiglet
approved these changes
Jul 14, 2025
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
…-tanzu#9063) * Add support for image registry proxy in Kibishii installation Signed-off-by: Priyansh Choudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Kibishi Images don't use the Image Registry Proxy we pass, this will allow those images also to respect the parameter passed.
/kind changelog-not-requiredFixes #(issue)
None
Please indicate you've done the following: