Skip to content

Conversation

@Lyndon-Li
Copy link
Contributor

Fix #8344, add a mechanism to soothe creation of data mover pods for DataUpload, DataDownload, PodVolumeBackup and PodVolumeRestore

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 57.73585% with 112 lines in your changes missing coverage. Please review.

Project coverage is 60.28%. Comparing base (4f06b6e) to head (454564a).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
pkg/exposer/vgdp_counter.go 32.66% 101 Missing ⚠️
pkg/cmd/cli/nodeagent/server.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9064      +/-   ##
==========================================
- Coverage   60.31%   60.28%   -0.04%     
==========================================
  Files         378      379       +1     
  Lines       42822    43066     +244     
==========================================
+ Hits        25830    25964     +134     
- Misses      15438    15548     +110     
  Partials     1554     1554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review July 4, 2025 10:15
@github-actions github-actions bot requested review from blackpiglet and kaovilai July 4, 2025 10:15
@github-actions github-actions bot added the Area/Design Design Documents label Jul 4, 2025
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-8344-3 branch 9 times, most recently from 6bc1c71 to 0269c9e Compare July 7, 2025 05:00
Copy link
Collaborator

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration Validation: Add validation for PrepareQueueLength to ensure it's a
positive number
Documentation: The PR would benefit from:
- Documentation on how to configure PrepareQueueLength

@Lyndon-Li
Copy link
Contributor Author

Configuration Validation: Add validation for PrepareQueueLength to ensure it's a positive number Documentation: The PR would benefit from: - Documentation on how to configure PrepareQueueLength

The validation is here:
if s.dataPathConfigs != nil && s.dataPathConfigs.LoadConcurrency != nil && s.dataPathConfigs.LoadConcurrency.PrepareQueueLength > 0.

Documentation will be in a separate PR after this one is merged.

@Lyndon-Li Lyndon-Li requested a review from kaovilai July 10, 2025 06:54
@blackpiglet blackpiglet merged commit 06d305e into vmware-tanzu:main Jul 18, 2025
44 of 46 checks passed
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Jul 23, 2025
* issue 8344: constrain data path exposure.

Signed-off-by: Lyndon-Li <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
* issue 8344: constrain data path exposure.

Signed-off-by: Lyndon-Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce excessive number of running datamovers relative to loadConcurrency values

3 participants