Design for node agent soothing #9067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
force-pushed
the
issue-fix-8344-design
branch
from
8a5af59 to
67e8de6
Compare
Lyndon-Li
requested review from
kaovilai,
shubham-pampattiwar,
sseago and
ywk253100
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9067 +/- ##
=======================================
Coverage 60.31% 60.31%
=======================================
Files 378 378
Lines 42822 42822
=======================================
Hits 25830 25830
Misses 15438 15438
Partials 1554 1554 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sseago
previously approved these changes
Jul 9, 2025
kaovilai
reviewed
Jul 10, 2025
Lyndon-Li
force-pushed
the
issue-fix-8344-design
branch
from
1d6c863 to
edd3cec
Compare
Lyndon-Li
force-pushed
the
issue-fix-8344-design
branch
from
aa83963 to
1b005be
Compare
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
issue-fix-8344-design
branch
from
18a6265 to
b4da037
Compare
kaovilai
reviewed
Jul 11, 2025
| This could cause below problems: | ||
| - In some environments, there is a pod limit in each node of the cluster or a pod limit throughout the cluster, too many of the inactive data mover pods may block other pods from running | ||
| - In some environments, the system disk for each node of the cluster is limited, while pods also occupy system disk space, etc., many of the inactive data mover pods also take unnecessary space from system disk and cause other critical pods evicted | ||
| - For CSI snapshot data movement backup, before creation of the data mover pod, the volume snapshot has also created, this means excessive number of snapshots may also be created and live for longer time since the VGDP won't start until the quota is available. However, in some environments, large number of snapshots is not allowed or may cause degradation of the storage peroformance |
Collaborator
There was a problem hiding this comment.
Suggested change
| - For CSI snapshot data movement backup, before creation of the data mover pod, the volume snapshot has also created, this means excessive number of snapshots may also be created and live for longer time since the VGDP won't start until the quota is available. However, in some environments, large number of snapshots is not allowed or may cause degradation of the storage peroformance | |
| - For CSI snapshot data movement backup, before creation of the data mover pod, the volume snapshot has also created, this means excessive number of snapshots may also be created and live for longer time since the VGDP won't start until the quota is available. However, in some environments, large number of snapshots is not allowed or may cause degradation of the storage performance |
blackpiglet
approved these changes
Jul 16, 2025
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Lyndon-Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8344, add the design for a mechanism to soothe creation of data mover pods for DataUpload, DataDownload, PodVolumeBackup and PodVolumeRestore