Refactor Snapshot Checkpoint in E2E Tests #9083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/kind changelog-not-required |
github-actions
bot
added
has-e2e-2tests
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9083 +/- ##
=======================================
Coverage 60.05% 60.05%
=======================================
Files 379 379
Lines 43153 43153
=======================================
Hits 25917 25917
Misses 15691 15691
Partials 1545 1545 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
priyansh17
changed the title
Collaborator
|
dco |
priyansh17
force-pushed
the
update-snapshot-checkpoint
branch
from
c6c6825 to
dd96d82
Compare
Collaborator
|
@blackpiglet can you review this one |
blackpiglet
reviewed
Jul 17, 2025
blackpiglet
reviewed
Jul 17, 2025
blackpiglet
approved these changes
Jul 21, 2025
…g in e2e tests Signed-off-by: Priyansh Choudhary <[email protected]> log backup volume info retrieval and snapshot checkpoint building Signed-off-by: Priyansh Choudhary <[email protected]> Add error handling for volume info retrieval in backup tests Signed-off-by: Priyansh Choudhary <[email protected]> Add error handling for volume info retrieval in backup tests Signed-off-by: Priyansh Choudhary <[email protected]>
Signed-off-by: Priyansh Choudhary <[email protected]>
blackpiglet
force-pushed
the
update-snapshot-checkpoint
branch
from
e271be9 to
cdedf81
Compare
anshulahuja98
approved these changes
Jul 21, 2025
kaovilai
pushed a commit
to kaovilai/velero
that referenced
this pull request
Jul 23, 2025
* Refactor backup volume info retrieval and snapshot checkpoint building in e2e tests Signed-off-by: Priyansh Choudhary <[email protected]> log backup volume info retrieval and snapshot checkpoint building Signed-off-by: Priyansh Choudhary <[email protected]> Add error handling for volume info retrieval in backup tests Signed-off-by: Priyansh Choudhary <[email protected]> Add error handling for volume info retrieval in backup tests Signed-off-by: Priyansh Choudhary <[email protected]> * Update snapshot checkpoint building to use DefaultKibishiiWorkerCounts Signed-off-by: Priyansh Choudhary <[email protected]> --------- Signed-off-by: Priyansh Choudhary <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
* Refactor backup volume info retrieval and snapshot checkpoint building in e2e tests Signed-off-by: Priyansh Choudhary <[email protected]> log backup volume info retrieval and snapshot checkpoint building Signed-off-by: Priyansh Choudhary <[email protected]> Add error handling for volume info retrieval in backup tests Signed-off-by: Priyansh Choudhary <[email protected]> Add error handling for volume info retrieval in backup tests Signed-off-by: Priyansh Choudhary <[email protected]> * Update snapshot checkpoint building to use DefaultKibishiiWorkerCounts Signed-off-by: Priyansh Choudhary <[email protected]> --------- Signed-off-by: Priyansh Choudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Post the Changes done in Clean artifacts generated by CSI backup and restore by blackpiglet · Pull Request #8684 · vmware-tanzu/velero we no longer preserve VSC.
Does your change fix a particular issue?
We were relying on VSC CR to check for Checkpoint, in this update method I have revised it to use Backup VolumeInfo json we create in object storage.
Fixes #(issue)
None
Please indicate you've done the following: