Skip to content

Conversation

@blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 21, 2025

Thank you for contributing to Velero!

Please add a summary of your change

This PR adds support for inheriting imagePullSecrets from the Velero server deployment to all pods created by Velero, including:

  • Volume snapshot data movement (VGDP) backup and restore pods
  • CSI snapshot exposer pods
  • Repository maintenance job pods

This ensures that helper pods can pull images from private registries using the same credentials configured for the main Velero deployment.

Additionally, this PR adds DNS configuration inheritance to the pod volume exposer pods for consistency with other pod types.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.04%. Comparing base (60a6c73) to head (8e0af81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9096      +/-   ##
==========================================
+ Coverage   59.03%   59.04%   +0.01%     
==========================================
  Files         379      379              
  Lines       43497    43509      +12     
==========================================
+ Hits        25678    25690      +12     
  Misses      16290    16290              
  Partials     1529     1529              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blackpiglet blackpiglet force-pushed the add_image_pull_secret branch 2 times, most recently from 8bcb8f2 to 6cc1ea7 Compare July 23, 2025 10:04
@blackpiglet blackpiglet marked this pull request as ready for review July 23, 2025 10:05
@github-actions github-actions bot requested review from Lyndon-Li and ywk253100 July 23, 2025 10:05
ywk253100
ywk253100 previously approved these changes Jul 23, 2025
@blackpiglet blackpiglet force-pushed the add_image_pull_secret branch from 6cc1ea7 to 643331c Compare July 23, 2025 11:05
@blackpiglet blackpiglet force-pushed the add_image_pull_secret branch 2 times, most recently from cbbdb2b to fa65f59 Compare July 23, 2025 11:52
@blackpiglet blackpiglet force-pushed the add_image_pull_secret branch from fa65f59 to 8e0af81 Compare July 23, 2025 15:08
@kaovilai kaovilai merged commit 770ff14 into vmware-tanzu:main Jul 23, 2025
46 checks passed
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants